Fix return types for Taxrate controllers and remove unused classes for Payment controller.

This commit is contained in:
2025-01-18 11:19:11 +01:00
parent d25a67a109
commit 372a417aaf
3 changed files with 10 additions and 9 deletions

View File

@@ -4,6 +4,7 @@ namespace App\Http\Controllers\Api;
use App\Http\Controllers\Controller;
use App\Models\Taxrate;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
class TaxrateController extends Controller
@@ -11,7 +12,7 @@ class TaxrateController extends Controller
/**
* Display a listing of the resource.
*/
public function index()
public function index(): JsonResponse
{
return response()->json(Taxrate::all());
}
@@ -19,7 +20,7 @@ class TaxrateController extends Controller
/**
* Store a newly created resource in storage.
*/
public function store(Request $request)
public function store(Request $request): JsonResponse
{
$taxData = $request->validate([
'name' => 'required|string',
@@ -36,7 +37,7 @@ class TaxrateController extends Controller
/**
* Update the specified resource in storage.
*/
public function update(Request $request, Taxrate $taxrate)
public function update(Request $request, Taxrate $taxrate): JsonResponse
{
$taxData = $request->validate([
'name' => 'required|string',
@@ -52,10 +53,10 @@ class TaxrateController extends Controller
/**
* Remove the specified resource from storage.
*/
public function destroy(Taxrate $taxrate)
public function destroy(Taxrate $taxrate): JsonResponse
{
$taxrate->delete();
return response()->json();
return response()->json(null, 204);
}
}

View File

@@ -4,7 +4,6 @@ namespace App\Http\Controllers;
use App\Models\Payment;
use Illuminate\Contracts\View\View;
use Illuminate\Http\Request;
class PaymentController extends Controller
{

View File

@@ -3,13 +3,14 @@
namespace App\Http\Controllers;
use App\Models\Taxrate;
use Illuminate\Contracts\View\View;
class TaxrateController extends Controller
{
/**
* Display a listing of the resource.
*/
public function index()
public function index(): View
{
return view('taxrate.index');
}
@@ -17,7 +18,7 @@ class TaxrateController extends Controller
/**
* Show the form for creating a new resource.
*/
public function create()
public function create(): View
{
return view('taxrate.create');
}
@@ -25,7 +26,7 @@ class TaxrateController extends Controller
/**
* Show the form for editing the specified resource.
*/
public function edit(Taxrate $taxrate)
public function edit(Taxrate $taxrate): View
{
return view('taxrate.edit', ['taxrate' => $taxrate]);
}